Fail-safe handling of nullable string value in lookupStyle #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the lookupStyle method in StyleUtils return a string. On old browsers getPropertyValue() of getComputedStyle() returns a null instead of empty string. Fixes angular#958
CaerusKaru
added
pr: lgtm
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we've been doing some research to find out why the flex layout library throws errors on older browsers. More specifically, Safari on iOS 8 and below.
This issue reports about this error: #958 - it says it's a duplicate of #947, however, these errors seem slightly unrelated.
The problem is the
lookupStylemethod in theStyleUtilsservice callsgetComputedStyle(element).getPropertyValue(styleName). The spec says thatgetPropertyValueshould return an empty string if the style is not set, however, on some older browsers it returnsnullinstead. This causes an error when the method returnsvalue.trim(), since value isn't a string.This PR adds a safeguard to check for
nulland makes sure the method always return a string.We've tested this on multiple old browsers on Browserstack and this seems to solve all our issues.